----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63592/#review190209 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp Line 9629 (original), 9629 (patched) <https://reviews.apache.org/r/63592/#comment267498> Can we take this by `const` ref since we don't take ownership? src/master/master.cpp Lines 9641 (patched) <https://reviews.apache.org/r/63592/#comment267494> Let's either initialize this variable with a good default or use an `Option` with a `CHECK`. src/master/master.cpp Lines 9645 (patched) <https://reviews.apache.org/r/63592/#comment267497> Should we `CHECK(operation->has_latest_status())` and somewhere above? src/master/master.cpp Lines 9665 (patched) <https://reviews.apache.org/r/63592/#comment267500> Should this be `UUID::fromBytes`? src/master/master.cpp Lines 9719 (patched) <https://reviews.apache.org/r/63592/#comment267495> Can be a `const` ref. - Benjamin Bannier On Nov. 6, 2017, 7:55 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63592/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2017, 7:55 p.m.) > > > Review request for mesos, Benjamin Bannier and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > Implemented updateOfferOperation in the master. > > > Diffs > ----- > > src/master/master.cpp f349fec8b61fa424c63d77253b6ab3ded08c8cdb > > > Diff: https://reviews.apache.org/r/63592/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
