----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61128/#review190253 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp Lines 9674-9676 (original), 9675-9678 (patched) <https://reviews.apache.org/r/61128/#comment267556> To be consistent with this log message, I think we also need to change the log message in `Master::removeTask()` from: ``` LOG(INFO) << "Removing task " << task->task_id() << " with resources " << task->resources() << " of framework " << task->framework_id() << " on agent " << *slave; ``` to: ``` LOG(INFO) << "Removing task " << task->task_id() << " of framework " << task->framework_id() << " with resources " << task->resources() << " on agent " << *slave; ``` And there is also a warning message in `Master::removeTask()`, I think we need to change that one too. - Qian Zhang On July 26, 2017, 7:46 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61128/ > ----------------------------------------------------------- > > (Updated July 26, 2017, 7:46 a.m.) > > > Review request for mesos and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Made the log messages more consistent and also added one for adding > an executor. > > > Diffs > ----- > > src/master/master.cpp e12c997dad04f8a4ddb47a993a84b2b05c9e2f32 > > > Diff: https://reviews.apache.org/r/61128/diff/1/ > > > Testing > ------- > > None > > > Thanks, > > Vinod Kone > >
