----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63655/#review190421 -----------------------------------------------------------
Patch looks great! Reviews applied: [63654, 63655] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Nov. 8, 2017, 1:14 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63655/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2017, 1:14 a.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-8156 > https://issues.apache.org/jira/browse/MESOS-8156 > > > Repository: mesos > > > Description > ------- > > Started using to `net::socketpair` in `ns::clone` so that we don't have > to deal with `SOCK_CLOEXEC` portability. > > > Diffs > ----- > > src/linux/ns.cpp 33751b518e95f4f67e6864728e1fdf621f50dd52 > > > Diff: https://reviews.apache.org/r/63655/diff/1/ > > > Testing > ------- > > make check (Fedora 26, macOS) > > > Thanks, > > James Peach > >
