----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63682/#review190531 -----------------------------------------------------------
Patch looks great! Reviews applied: [63270, 63280, 63682] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Nov. 9, 2017, 5:14 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63682/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2017, 5:14 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and > Jie Yu. > > > Bugs: MESOS-8128 > https://issues.apache.org/jira/browse/MESOS-8128 > > > Repository: mesos > > > Description > ------- > > The `NestedMesosContainerizerTest` and `DefaultExecutorCheckTest` > tests depend on the pipe file descriptors being inherited across > exec. Ensure that we toggle `O_CLOEXEC` off to meet the test > expectations. > > > Diffs > ----- > > src/tests/check_tests.cpp d3ffc0b0204d021f1ed734ece189d0e3a3fd8844 > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > 3e2a2d151759e78686e90e84322c9fd348c86a04 > > > Diff: https://reviews.apache.org/r/63682/diff/1/ > > > Testing > ------- > > sudo make check (Fedora 26) > > > Thanks, > > James Peach > >
