----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63622/#review190547 -----------------------------------------------------------
src/slave/slave.cpp Lines 6824-6851 (patched) <https://reviews.apache.org/r/63622/#comment268023> Can you move this to a helper call updateOfferOperation (like we did in the master)? src/slave/slave.cpp Lines 6916-6917 (patched) <https://reviews.apache.org/r/63622/#comment268027> I realize that we need to do that for Master as well. We should update `Slave::apply` to take `OfferOperation*` which will update slave's total resources. Here, in the Slave, we should introduce a similar method. src/slave/slave.cpp Lines 6961 (patched) <https://reviews.apache.org/r/63622/#comment268024> this should be in `removeOfferOperation`? - Jie Yu On Nov. 8, 2017, 4:12 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63622/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2017, 4:12 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Repository: mesos > > > Description > ------- > > When a resource provider has finished an offer operation, it will send > a status update to the resource provider manager and subsequently to an > agent. The agent then updates its internal bookkeeping and forwards the > status update to the master. > > > Diffs > ----- > > src/common/protobuf_utils.hpp 95f57da820db676874302f1c3138a76c22a88593 > src/common/protobuf_utils.cpp 7a4b87becbe73f0fa97ebceee6b71ede8dce90dd > src/resource_provider/manager.cpp a878507d71a09a415d8a4573cf2b33c26c985451 > src/resource_provider/message.hpp 3c7c3f2baeb726e04edd6ffbb9784699d7afe521 > src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 > src/slave/slave.cpp c10823985154bac19f8952b94311a03b2b9b4ea1 > src/tests/resource_provider_manager_tests.cpp > 4008b1c751d6227b99adef756e95174d7d8a62f2 > > > Diff: https://reviews.apache.org/r/63622/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
