----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63366/#review190721 -----------------------------------------------------------
3rdparty/Makefile.am Lines 126 (patched) <https://reviews.apache.org/r/63366/#comment268312> Formatting, use tabs 3rdparty/Makefile.am Lines 137-140 (original), 140-157 (patched) <https://reviews.apache.org/r/63366/#comment268320> "NASA Spent Millions to Develop a Pen that Would Write in Space, whereas the Soviet Cosmonauts Used a Pencil" — a famous urban legend. So why not just repack jemalloc archive into gzip instead? configure.ac Lines 213 (patched) <https://reviews.apache.org/r/63366/#comment268315> Maybe "jemalloc-allocator"? Or "bundled-jemalloc"? configure.ac Line 775 (original), 794 (patched) <https://reviews.apache.org/r/63366/#comment268309> What is the change here? configure.ac Lines 1144-1147 (original), 1206-1209 (patched) <https://reviews.apache.org/r/63366/#comment268310> Is this change on purpose? configure.ac Lines 1154-1157 (original), 1216-1219 (patched) <https://reviews.apache.org/r/63366/#comment268311> Ditto? - Alexander Rukletsov On Oct. 27, 2017, 7:03 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63366/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2017, 7:03 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > This allows building and linking against the bundled > version of jemalloc when the --enable-jemalloc > configuration flag is specified. > > > Diffs > ----- > > 3rdparty/Makefile.am 687f52d9299bf9c6425c2ba7c35c050ff45a33cd > 3rdparty/jemalloc-5.0.1.tar.bz2 PRE-CREATION > 3rdparty/versions.am cbab26d3e303180c3f210f0c5f45613a5c8c96ba > configure.ac 067005e1be3a09e8320be120c8784f195e30ac5d > src/Makefile.am b60a54a031260de6f1fb43584ae5083df2dc7e31 > > > Diff: https://reviews.apache.org/r/63366/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
