----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63613/#review190842 -----------------------------------------------------------
Ship it! Ship It! - James Peach On Nov. 7, 2017, 12:58 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63613/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2017, 12:58 p.m.) > > > Review request for mesos, Michael Park and Vinod Kone. > > > Bugs: MESOS-8096 > https://issues.apache.org/jira/browse/MESOS-8096 > > > Repository: mesos > > > Description > ------- > > The shared pointer to MockHTTPExecutor is initialized after the library, > while the library may start using it right after its initialization via > the `events` callback. This change removes the shared pointer altogether > and hence prevents possible segfaults. > > > Diffs > ----- > > src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59 > > > Diff: https://reviews.apache.org/r/63613/diff/1/ > > > Testing > ------- > > See https://reviews.apache.org/r/63615/ > > > Thanks, > > Alexander Rukletsov > >
