> On Aug. 28, 2017, 8:26 p.m., Jie Yu wrote: > > include/mesos/agent/agent.proto > > Line 65 (original), 67 (patched) > > <https://reviews.apache.org/r/60890/diff/2/?file=1806336#file1806336line67> > > > > We should deprecate this as well. `REMOVE_CONTAINER` will be useful for > > standalone container as well (to remove the runtime dir which won't be > > deleted until this call).
Re-opening this because I'm undo-ing the addition of a `RemoveContainer` call (and keeping the `RemoveNestedContainer` call non-deprecated). Consider dropping the issue if you agree with my reasoning: As it currently stands, `Containerizer::remove` is only intended for nested containers launched in a loop under a long-lived parent container. The runtime artifacts of standalone containers will be removed upon destruction like any other parent container. (Note that nested containers under a standalone container are considered nested containers.) - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60890/#review184020 ----------------------------------------------------------- On Nov. 2, 2017, 8:50 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60890/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2017, 8:50 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-7305 > https://issues.apache.org/jira/browse/MESOS-7305 > > > Repository: mesos > > > Description > ------- > > Launching a standalone container is very similar to launching a > nested container, except that the caller must specify some Resources. > As such, this patch deprecates some nested container APIs > and replaces them with more generically named APIs. > > This applies to the Launch, Wait, Kill, and Remove > (nested) container APIs. > > > Diffs > ----- > > include/mesos/agent/agent.proto 4df3dcef4bd1d42cb8b4955e290bd38038355e46 > include/mesos/v1/agent/agent.proto e99d23d55a0951f2ed728360e103d83ea5a1ad7f > > > Diff: https://reviews.apache.org/r/60890/diff/5/ > > > Testing > ------- > > make > > See later patches in chain. > > > Thanks, > > Joseph Wu > >
