> On Nov. 10, 2017, 5:14 p.m., Akash Gupta wrote: > > 3rdparty/stout/include/stout/windows/os.hpp > > Lines 745 (patched) > > <https://reviews.apache.org/r/63269/diff/1/?file=1869641#file1869641line745> > > > > Just realized this, but I don't think function works if your machine > > has > 64 CPUs. It calls GetSystemInfo, which returns the cpus of the > > "current" group, which is 64 max. Call > > GetMaximumProcessorCount(ALL_PROCESSOR_GROUPS) to get the right number. > > There was a bug fix in python with a similar issue to this: > > https://github.com/python/cpython/commit/c67bae04780f9d7590f9f91b4ee5f31c5d75b3c3 > > Andrew Schwartzmeyer wrote: > That's a good point, but it's separate issue I'll file.
https://issues.apache.org/jira/browse/MESOS-8216 - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63269/#review190770 ----------------------------------------------------------- On Nov. 2, 2017, 1:39 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63269/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2017, 1:39 p.m.) > > > Review request for mesos, Aaron Wood, Akash Gupta, Jeff Coffler, Jie Yu, John > Kordich, Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > This is used to set a hard cap on the CPU usage for a job object. > > > Diffs > ----- > > 3rdparty/stout/include/stout/windows/os.hpp > 09ddec6d69472cd13b453fe1a77fdbe343fc23c8 > > > Diff: https://reviews.apache.org/r/63269/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
