----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62997/#review190888 -----------------------------------------------------------
Fix it, then Ship it! LGTM! src/slave/containerizer/mesos/provisioner/provisioner.cpp Lines 51 (patched) <https://reviews.apache.org/r/62997/#comment268444> Move it right below `slave/paths.hpp` src/slave/containerizer/mesos/provisioner/provisioner.cpp Lines 514 (patched) <https://reviews.apache.org/r/62997/#comment268445> one more space after `foreach` src/slave/containerizer/mesos/provisioner/provisioner.cpp Lines 519 (patched) <https://reviews.apache.org/r/62997/#comment268446> kill this line src/slave/containerizer/mesos/provisioner/provisioner.cpp Lines 521 (patched) <https://reviews.apache.org/r/62997/#comment268448> return Failure("Failed to checkpoint layers to '" + path + "': " + checkpoint.error()); - Gilbert Song On Nov. 10, 2017, 11:33 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62997/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2017, 11:33 a.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. > > > Bugs: MESOS-8079 > https://issues.apache.org/jira/browse/MESOS-8079 > > > Repository: mesos > > > Description > ------- > > Added checkpoint and recover capability for layers in provisioner. > > > Diffs > ----- > > include/mesos/slave/containerizer.proto > 689acfcbbb07f071b6195472118a7a7520a44abd > src/slave/containerizer/mesos/provisioner/paths.hpp > 466f5edab40732b0d8da4252a71fde9c2956e8e9 > src/slave/containerizer/mesos/provisioner/paths.cpp > 268dbeb4b18374ef53bc73254bf20ce6830e384f > src/slave/containerizer/mesos/provisioner/provisioner.hpp > 7cba54ce490d1e6e17081cd7e04fd6759ceddb8e > src/slave/containerizer/mesos/provisioner/provisioner.cpp > 450a3b32d69d2882973a6ed4e94e169a0256056b > > > Diff: https://reviews.apache.org/r/62997/diff/4/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
