----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63730/#review190948 -----------------------------------------------------------
Fix it, then Ship it! Please rebase, the formatting fix in `message.hpp` is already fixed in `master`. src/resource_provider/manager.cpp Line 477 (original), 477 (patched) <https://reviews.apache.org/r/63730/#comment268523> Remove the space after `resourceProvider`. - Jan Schlicht On Nov. 13, 2017, 7:33 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63730/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2017, 7:33 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-8207 > https://issues.apache.org/jira/browse/MESOS-8207 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/resource_provider/manager.cpp bcc833b6c96344762a693dd6d4e0a9129aa735f8 > src/resource_provider/message.hpp a1a84c1fd374b740c56ed2175ee5a2dbc8f96dbc > > > Diff: https://reviews.apache.org/r/63730/diff/1/ > > > Testing > ------- > > `make check`, still need to implement dedicated tests. > > > Thanks, > > Benjamin Bannier > >
