> On Nov. 14, 2017, 5:40 p.m., Jie Yu wrote:
> > src/slave/slave.cpp
> > Line 3720 (original), 3731 (patched)
> > <https://reviews.apache.org/r/63751/diff/2/?file=1890638#file1890638line3731>
> >
> > Let's add a CHECK here to test the operation is old operation.
> >
> > ```
> > CHECK(protobuf::isSpeculativeOperation(message.operation_info()));
> > ```
maybe just do
```
CHECK(message.operation_info().type() == Offer::Operation::RESERVE ||
message.operation_info().type() == Offer::Operation::UNRESERVE ||
message.operation_info().type() == Offer::Operation::CREATE ||
message.operation_info().type() == Offer::Operation::DESTROY);
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63751/#review190963
-----------------------------------------------------------
On Nov. 13, 2017, 2:21 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63751/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2017, 2:21 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-8211
> https://issues.apache.org/jira/browse/MESOS-8211
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Agents the have the 'RESOURCE_PROVIDER' capability set, should get sent
> 'ApplyOfferOperationMessage' instead of 'CheckpointResourcesMessage'.
> The agent will then figure out how to apply the operation. For agent
> local resources the agent will checkpoint resources.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 0ca4c6d689bf7d2c477174b039432ed7b6d0b650
> src/common/protobuf_utils.cpp 5739a63f8d87923c034375b88c4f0b3b19f4b521
> src/master/master.cpp 49dbaa979d692061a7b479b1db4511e8357b8baf
> src/slave/slave.cpp 7cb6661b55fb5437a1ffc447f974076aadd1eced
> src/tests/reservation_tests.cpp 470f7341686e69d0a71fb234a26b277c45c29780
>
>
> Diff: https://reviews.apache.org/r/63751/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
