> On Nov. 14, 2017, 9:07 a.m., Akash Gupta wrote: > > src/tests/containerizer/cpu_isolator_tests.cpp > > Line 251 (original), 270 (patched) > > <https://reviews.apache.org/r/63277/diff/2/?file=1882404#file1882404line270> > > > > Personally, I think it makes sense to increase this time on Windows. > > Powershell takes some time to start up, so one second isn't enough.
Yeah, we could probably adjust the timings to get a non-flaky test. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63277/#review190964 ----------------------------------------------------------- On Nov. 6, 2017, 3:19 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63277/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2017, 3:19 p.m.) > > > Review request for mesos, Aaron Wood, Akash Gupta, Jeff Coffler, Jie Yu, John > Kordich, Joseph Wu, Li Li, and Michael Park. > > > Bugs: MESOS-6690 > https://issues.apache.org/jira/browse/MESOS-6690 > > > Repository: mesos > > > Description > ------- > > These test the limitation and usage reporting of the new Windows `Cpu` > and `Mem` isolators. > > > Diffs > ----- > > src/tests/CMakeLists.txt 81c85d9bb1b50c6897526d5c207d09042883d771 > src/tests/containerizer/cpu_isolator_tests.cpp > 846b2e255547a02f5eb0590747edca62bc560ac3 > src/tests/containerizer/memory_isolator_tests.cpp > b8ea5d35b3a0a4820d9ec4c6d7d916dc6101b570 > src/tests/mesos.cpp 9185b5bf2175be5b0f6b6a03a04e9e5445bf22fd > > > Diff: https://reviews.apache.org/r/63277/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
