> On Nov. 14, 2017, 7:18 p.m., Gaston Kleiman wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 72-75 (patched) > > <https://reviews.apache.org/r/63804/diff/1/?file=1892039#file1892039line72> > > > > Isn't the idea to use this message only when the master wants to check > > if an operation was received by the RP or dropped on its way? > > > > In such case the RP should only generate an offer operation status > > update if the operation is unknown; the state of this update would be > > `OFFER_OPERATION_DROPPED`.
Yep you're right, thanks :) - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63804/#review190991 ----------------------------------------------------------- On Nov. 14, 2017, 6:41 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63804/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2017, 6:41 p.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-8199 > https://issues.apache.org/jira/browse/MESOS-8199 > > > Repository: mesos > > > Description > ------- > > This patch adds new internal protobuf messages to be used by the master > and agent when reconciling pending/unacknowledged offer operations. > > > Diffs > ----- > > include/mesos/resource_provider/resource_provider.proto > 1e44b952691fa57b546e979bc5876df3d82d746f > src/messages/messages.proto 33732e28d087a17080eb9aa7d9a91c367172be7f > src/resource_provider/storage/provider.cpp > 46224997430ac0c568904d80014166a6f059907f > > > Diff: https://reviews.apache.org/r/63804/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Greg Mann > >
