----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review191026 -----------------------------------------------------------
Some suggestions from going over it together: * Maybe add an optional duration to the profiling start request? I personally would want to enable it on a window basis so that I don't have to remember to follow up and stop to prevent an OOM. * Could we look into the ability to get a profile that has the symbols resolved? (i.e. "--raw"?) That way, we could analyze the profile on a different machine or on a mac laptop. * In the markdown documentation, in addition to the changes we made, it would be good to explain what the different profiles are (image vs text vs raw). - Benjamin Mahler On Oct. 27, 2017, 7:04 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63368/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2017, 7:04 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > This class exposes profiling functionality of jemalloc memory allocator > when it is detected to be the memory allocator of the current process. > > In particular, it gives developers an easy method to collect and > access heap profiles which report which pieces of code were > responsible for allocating memory. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 03a0ca87f31744c716c99e05aa07242fed480675 > 3rdparty/libprocess/include/process/memory_profiler.hpp PRE-CREATION > 3rdparty/libprocess/include/process/process.hpp > dc3375ce62556322eb2bc60ade61f313ade123b8 > 3rdparty/libprocess/src/memory_profiler.cpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp > 71ae7129ffbd0e22eda2863b17bbcf588298c37b > > > Diff: https://reviews.apache.org/r/63368/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
