----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63829/ -----------------------------------------------------------
Review request for mesos, Gilbert Song, Jie Yu, and Zhitao Li. Repository: mesos Description ------- This includes two changes: 1) Containerizer::remove no longer CHECKs for a nested container as input and accepts standalone containers too. 2) Standalone containers no longer have their runtime directory deleted upon exit (which funnily, would prevent the containerizer from figuring out that the ContainerID is a standalone). This change means that, for standalone containers, the caller will need to explicitly remove the standalone container with the REMOVE_CONTAINER API. Diffs ----- src/slave/containerizer/mesos/containerizer.cpp db5f044f7415386c94e4930f365dfc14d403414a src/tests/agent_container_api_tests.cpp 595ce510783b6cdf219eadd287c57bd576d6443b Diff: https://reviews.apache.org/r/63829/diff/1/ Testing ------- Doesn't build at the moment, as the dependent review needs a rebase (due to my earlier changes :) ) Thanks, Joseph Wu