----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63844/#review191093 -----------------------------------------------------------
src/slave/slave.cpp Lines 3791-3798 (patched) <https://reviews.apache.org/r/63844/#comment268685> The `operation_uuid` here is the Mesos internal UUID, not the framework-generated `OperationID`; the translation between these two occurs in the master, so that the agent/RP never needs to interact with the framework-generated ID. So we probably don't need the quotes around this UUID in our logging, and perhaps we could use a `CHECK_SOME` instead of the `if` after we convert to `UUID`? - Greg Mann On Nov. 15, 2017, 5:31 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63844/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2017, 5:31 p.m.) > > > Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/slave.cpp d8bacebc74790e955490a158c37ac0d9e75fd6b5 > > > Diff: https://reviews.apache.org/r/63844/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
