----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60471/#review191288 -----------------------------------------------------------
src/tests/containerizer/mesos_containerizer_tests.cpp Lines 923 (patched) <https://reviews.apache.org/r/60471/#comment269058> ditto. src/tests/containerizer/mesos_containerizer_tests.cpp Lines 1199 (patched) <https://reviews.apache.org/r/60471/#comment269067> if you just need to prove the image reference is correct. why do you need this promise? src/tests/containerizer/mesos_containerizer_tests.cpp Lines 1229 (patched) <https://reviews.apache.org/r/60471/#comment269066> const string imageName = "fake-image"; src/tests/containerizer/mesos_containerizer_tests.cpp Lines 1231-1235 (patched) <https://reviews.apache.org/r/60471/#comment269062> use createDockerImage(). src/tests/containerizer/mesos_containerizer_tests.cpp Lines 1237-1242 (patched) <https://reviews.apache.org/r/60471/#comment269063> use createContainerInfo() src/tests/containerizer/mesos_containerizer_tests.cpp Lines 1244-1246 (patched) <https://reviews.apache.org/r/60471/#comment269064> use createTask() src/tests/containerizer/mesos_containerizer_tests.cpp Lines 1266 (patched) <https://reviews.apache.org/r/60471/#comment269068> do you really need to wait for the termination? src/tests/containerizer/mesos_containerizer_tests.cpp Lines 1275 (patched) <https://reviews.apache.org/r/60471/#comment269065> 1u for vector? - Gilbert Song On Nov. 16, 2017, 1:36 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60471/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2017, 1:36 p.m.) > > > Review request for mesos, Gilbert Song and Jason Lai. > > > Bugs: MESOS-4945 > https://issues.apache.org/jira/browse/MESOS-4945 > > > Repository: mesos > > > Description > ------- > > Added tests for pruneImages for containerizer and provisioner. > > > Diffs > ----- > > src/tests/containerizer/mesos_containerizer_tests.cpp > ce67def65aa65188aff10f5316fcd8b745d0abf2 > src/tests/containerizer/provisioner_docker_tests.cpp > 832c81fe88d753b0f00dfab870d7725cf556fcef > > > Diff: https://reviews.apache.org/r/60471/diff/10/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
