> On Nov. 16, 2017, 1:23 a.m., Jie Yu wrote: > > src/slave/slave.cpp > > Line 6722 (original), 6722 (patched) > > <https://reviews.apache.org/r/63731/diff/2/?file=1893484#file1893484line6722> > > > > I suggest we change this to `UPDATE_STATE` to align with the RP API > > because we also update operations (not just total resources).
I added an earlier patch in this chain, https://reviews.apache.org/r/63917/. > On Nov. 16, 2017, 1:23 a.m., Jie Yu wrote: > > src/slave/slave.cpp > > Lines 6759-6772 (patched) > > <https://reviews.apache.org/r/63731/diff/2/?file=1893484#file1893484line6764> > > > > In Jan's patch, for old operations, `addOfferOperation` will update > > slave's `totalResources` because the operation will be speculatively > > applied. > > > > Then, what does that mean to remove those offer opeartion? RP's total > > resources should already contains all the conversions for old operations. > > > > Maybe it's not a good idea to update `totalResources` in > > `addOfferOperation`? `addOfferOperation` should only update `used` > > resources? Please think more on that. > > > > Also, if we decide to do the above, make sure master code is consistent > > as well. > > > > Please sync with Jan on this. I agree that we should probably pull changes to the total resources out of `addOfferOperation` (mainly since the updates to `total` and e.g., `operations` are coupled, but the method works on smaller granularity leading to a mismatch). This is not strictly required for this patch chain and I would suggest cleaning this up in a later patch. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/#review191108 ----------------------------------------------------------- On Nov. 17, 2017, 6:24 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63731/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2017, 6:24 p.m.) > > > Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-8207 > https://issues.apache.org/jira/browse/MESOS-8207 > > > Repository: mesos > > > Description > ------- > > When resource providers update their state they send a list of > pending or unacknowledged operations to the agent. This patch add > tracking for such operations to the agent. The agent can then forward > these operations to the master, e.g., for calculating the unused > resources behind an agent. > > We track an operation until we either receive a updated list of > pending or unacknowledged operations from a resource provider, or > until we see an acknowledgement from a framework. This keeps the list > of operations bounded and ensures that we maintain the latest > information in the agent. > > > Diffs > ----- > > src/slave/slave.cpp d8edc5e6bbfa265bca4d19bbaa7db3063949dbc0 > > > Diff: https://reviews.apache.org/r/63731/diff/3/ > > > Testing > ------- > > `make check`, still need to implement dedicated tests. > > > Thanks, > > Benjamin Bannier > >
