-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63932/#review191450
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On Nov. 18, 2017, 12:03 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63932/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2017, 12:03 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> ```
> 3rdparty/libprocess/src/../include/process/future.hpp:1187:5: warning:
> 'callback' used after it was moved [misc-use-after-move]
>     callback();
>     ^
> 3rdparty/libprocess/src/../include/process/future.hpp:1181:32: note:
> move occurred here
>       data->onDiscardCallbacks.emplace_back(std::move(callback));
>                                ^
> ```
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 
> 4cf44ba1a7052d5f84beb8fd6914b8e9e0437c0a 
>   3rdparty/libprocess/src/http.cpp 8f95878824210229444ab7e0d2bdc6106c032444 
> 
> 
> Diff: https://reviews.apache.org/r/63932/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Reply via email to