> On Nov. 18, 2017, 11:06 a.m., Vinod Kone wrote: > > src/tests/scheduler_driver_tests.cpp > > Lines 96 (patched) > > <https://reviews.apache.org/r/63765/diff/1/?file=1891025#file1891025line96> > > > > we use camel case for our variable names in mesos and snake case in > > libprocess/stout > > > > s/in_sequence/inSequence/ > > > > btw, why is the sequence here necessary?
I want to make sure a call gets dropped first and then check expectation (no future calls). I think without the sequence, we can not enforce this order consistently? - Meng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63765/#review191445 ----------------------------------------------------------- On Nov. 18, 2017, 1:32 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63765/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2017, 1:32 p.m.) > > > Review request for mesos, Gilbert Song and Vinod Kone. > > > Bugs: MESOS-8171 > https://issues.apache.org/jira/browse/MESOS-8171 > > > Repository: mesos > > > Description > ------- > > When framework failover time is set to zero (which is the > default value), the scheduler driver subscribe backoff time > will also become zero. Ignore failover time if it is zero > when deciding the subscribe backoff time. > Also added a dedicated test. > > > Diffs > ----- > > src/sched/sched.cpp 6028499285ad092ffd252e842c5d9835dd4442f8 > src/tests/scheduler_driver_tests.cpp > 14d872b8fadfd4ef16d8923fb0df924331534bc3 > > > Diff: https://reviews.apache.org/r/63765/diff/2/ > > > Testing > ------- > > make check, and the new dedicated test. > > > Thanks, > > Meng Zhu > >
