----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61149/#review191463 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/include/process/future.hpp Lines 1785-1786 (patched) <https://reviews.apache.org/r/61149/#comment269285> Any reason not to? ``` return stream << "Abandoned" << suffix; ``` 3rdparty/libprocess/include/process/future.hpp Lines 1790-1792 (patched) <https://reviews.apache.org/r/61149/#comment269286> Likewise these cases could be more succinct with returns and no breaks? ``` case Future<T>::PENDING: return stream << "Pending" << suffix; case ... ``` - Benjamin Mahler On July 27, 2017, 1:55 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61149/ > ----------------------------------------------------------- > > (Updated July 27, 2017, 1:55 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > This is especially useful when creating error messages and the future > has failed or been discarded. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > a11a588941b02d776da2f563dd246a92dfbbc360 > 3rdparty/libprocess/src/tests/future_tests.cpp > 76a32bd69499e52ea1623ab982d65e1c7a0cbd32 > > > Diff: https://reviews.apache.org/r/61149/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
