----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63941/#review191466 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/hashmap.hpp Lines 34 (patched) <https://reviews.apache.org/r/63941/#comment269291> A little odd that we're depending on it from the hashset header. 3rdparty/stout/include/stout/hashset.hpp Lines 36 (patched) <https://reviews.apache.org/r/63941/#comment269290> Couldn't figure out how you came up with size_t here. Maybe mention why this is big enough and signedness doesn't matter? - Benjamin Mahler On Nov. 20, 2017, 1:02 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63941/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2017, 1:02 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Added support for enum's to hashset and hashmap. > > > Diffs > ----- > > 3rdparty/stout/include/stout/hashmap.hpp > 539bbfd9250f2f372c2b3211e2379ad2229fa35e > 3rdparty/stout/include/stout/hashset.hpp > d2f7d5ddba62cc87e2b61cb06c86b8ef4cd1a212 > > > Diff: https://reviews.apache.org/r/63941/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
