----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63912/#review191473 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp Lines 6257-6258 (patched) <https://reviews.apache.org/r/63912/#comment269317> Can we make this part of the `Slave`'s constructor (and no default value so that the caller will be forced to set it). src/master/master.cpp Lines 6847-6848 (patched) <https://reviews.apache.org/r/63912/#comment269318> Ditto. - Jie Yu On Nov. 17, 2017, 1:07 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63912/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2017, 1:07 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Repository: mesos > > > Description > ------- > > An agent will send its resource version UUIDs during (re-)registration. > The master will have to use them when sending a > 'ApplyOfferOperationMessage' to an agent. > This was missing in the master, the resource version were only set when > an agent sent a 'UpdateSlaveMessage'. This created situations where the > master would crash. > > > Diffs > ----- > > src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3 > src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f > > > Diff: https://reviews.apache.org/r/63912/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
