----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63959/#review191530 -----------------------------------------------------------
FAIL: Failed to apply the dependent review: 63638. Failed command: `python.exe .\support\apply-reviews.py -n -r 63638` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63959 Relevant logs: - [apply-review-63638-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63959/logs/apply-review-63638-stdout.log): ``` error: patch failed: 3rdparty/libprocess/include/process/future.hpp:155 error: 3rdparty/libprocess/include/process/future.hpp: patch does not apply ``` - Mesos Reviewbot Windows On Nov. 20, 2017, 11:51 a.m., Dmitry Zhuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63959/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2017, 11:51 a.m.) > > > Review request for mesos, Benjamin Mahler and Michael Park. > > > Repository: mesos > > > Description > ------- > > When master logs agent or task resources, it uses `operator <<` for raw > protobuf data, which outputs resources in JSON format, and is rather > slow. However resources are known to be valid and refined when logged by > master, so it's faster to use `operator <<` after protobuf is converted > to `Resources`. > This patch also factors out implicit conversions to `Resources` to avoid > multiple conversions. > > > Diffs > ----- > > src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3 > src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f > > > Diff: https://reviews.apache.org/r/63959/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Dmitry Zhuk > >
