----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63798/#review191639 -----------------------------------------------------------
src/slave/slave.cpp Lines 3532 (patched) <https://reviews.apache.org/r/63798/#comment269481> This is problematic. What if it's an old master but a new agent? old master will still send checkpointed resources message, and we'll miss updating the total in that case. I better approach is to pass an optional parameter to this method and let the caller control that. src/tests/resource_provider_manager_tests.cpp Line 805 (original), 713 (patched) <https://reviews.apache.org/r/63798/#comment269496> Do you want to have an ASSERT here checking if `resources` is not empty? - Jie Yu On Nov. 21, 2017, 3:30 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63798/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 3:30 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-8218 > https://issues.apache.org/jira/browse/MESOS-8218 > > > Repository: mesos > > > Description > ------- > > The `RESERVE`/`UNRESERVE`/`CREATE`/`DESTROY` operations for > reservations and persistent volumes have been enabled for resource > provider resources. Similar to agent resources, they are speculatively > applied to allow offer pipelining. > > > Diffs > ----- > > src/common/resources_utils.cpp 7c48704638dbfd0e0f5890765026537caf40e73c > src/master/master.cpp 7417b5d641fd4bb6d91cb0e6456c60201bbc8206 > src/slave/slave.cpp 6e9adc60f593faf1b0e56caeea04882f67af7080 > src/tests/resource_provider_manager_tests.cpp > ecfe2b4c0952838d6312df603f8eb2f458725175 > > > Diff: https://reviews.apache.org/r/63798/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
