----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63376/#review191678 -----------------------------------------------------------
Fix it, then Ship it! src/resource_provider/daemon.cpp Lines 182-184 (patched) <https://reviews.apache.org/r/63376/#comment269530> I'd just use `.put(info->name(), info.get())` here - Jie Yu On Nov. 20, 2017, 11:15 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63376/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2017, 11:15 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, Joseph Wu, and Jan > Schlicht. > > > Bugs: MESOS-8097 > https://issues.apache.org/jira/browse/MESOS-8097 > > > Repository: mesos > > > Description > ------- > > The local resource provider daemon is now started aftor we get a slave > id (either through registration or recovery). The slave id will be > eventually passed into each local resource provider for checkpointing > their metadata. > > > Diffs > ----- > > src/resource_provider/daemon.hpp ef6c356cb6ddb2594d767d7dd6052e9fd8df8263 > src/resource_provider/daemon.cpp d584eb9d7aa75522aec97277674321061b90fbed > src/slave/slave.cpp d8edc5e6bbfa265bca4d19bbaa7db3063949dbc0 > > > Diff: https://reviews.apache.org/r/63376/diff/3/ > > > Testing > ------- > > make > > > Thanks, > > Chun-Hung Hsiao > >
