----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62762/#review191689 -----------------------------------------------------------
Fix it, then Ship it! src/resource_provider/local.cpp Lines 46-47 (patched) <https://reviews.apache.org/r/62762/#comment269547> `#if defined(ENABLE_GRPC) && defined(__linux__)` src/resource_provider/storage/provider.cpp Lines 57 (patched) <https://reviews.apache.org/r/62762/#comment269543> Let's use `org.apache.mesos.rp.local.storage` here (rp.type) src/resource_provider/storage/provider.cpp Lines 62 (patched) <https://reviews.apache.org/r/62762/#comment269545> Let's verify that `-` is not allowed in either `type` or `name` because we say in the API that this should be in java package naming convension. - Jie Yu On Nov. 21, 2017, 12:07 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62762/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 12:07 a.m.) > > > Review request for mesos, Alexander Rojas, Greg Mann, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-8100 > https://issues.apache.org/jira/browse/MESOS-8100 > > > Repository: mesos > > > Description > ------- > > The `LocalResourceProvider::principal()` function takes a > `ResourceProviderInfo` and generates a principal with the following > claim: > > {"cid_prefix", name prefix for the resource provider} > > where the name prefix is a unique prefix for all containers that will be > launched by the resource provider. For example, for resource provider > with type 'org.apache.rp.local.storage' and name 'foo', the claim > would be: > > {"cid_prefix", "mesos-slrp-foo-"} > > In the future, we could add more claims for authorizing other > operations, such as authorization for Resource Provider API. > > > Diffs > ----- > > src/resource_provider/local.hpp ebaa07d03ad77d516066ee2d4b60864be0611b5f > src/resource_provider/local.cpp ad98f333c5668ca81de6e7ed3fc8f59323b151da > src/resource_provider/storage/provider.hpp > 6de88c2329b358fcf48bc39ddda0132170991c3c > src/resource_provider/storage/provider.cpp > 46224997430ac0c568904d80014166a6f059907f > > > Diff: https://reviews.apache.org/r/62762/diff/6/ > > > Testing > ------- > > make > > > Thanks, > > Chun-Hung Hsiao > >
