----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64053/#review191815 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Nov. 23, 2017, 3:19 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64053/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2017, 3:19 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-8263 > https://issues.apache.org/jira/browse/MESOS-8263 > > > Repository: mesos > > > Description > ------- > > An agent could run into a registration timeout and try to register a > second time. In that case the master will acknowledge the registration > twice. This is expected. As a result the agent would send > 'UpdateSlaveMessage' twice. The test expected the second > 'UpdateSlaveMessage' to be the result of a resource provider > registration, hence the test would fail. This has been resolved by > controlling the clock during registration to avoid registration > timeouts. > > > Diffs > ----- > > src/tests/resource_provider_manager_tests.cpp > ce4335b4209caf39347bec516d4820a515dd9c1d > > > Diff: https://reviews.apache.org/r/64053/diff/1/ > > > Testing > ------- > > ./bin/mesos-tests.sh --gtest_filter=*ConvertResources* --gtest_repeat=200 > --gtest_break_on_failure > > > Thanks, > > Jan Schlicht > >
