----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64054/#review191855 -----------------------------------------------------------
src/master/master.hpp Lines 2795-2841 (original) <https://reviews.apache.org/r/64054/#comment269789> This should still be part of `addOfferOperation`. In fact, anything to do with `used` resourecs should still be part of `addOfferOperation`. Only the part that's converting `total` resources should be pulled out because the way we change total does not rely on each offer operation. instead, we rely on the snapshot value received in `UpdateSlaveMessage`. src/master/master.cpp Lines 8608-8633 (patched) <https://reviews.apache.org/r/64054/#comment269790> See comments above. THis is not necessary. src/master/master.cpp Lines 9965-9995 (patched) <https://reviews.apache.org/r/64054/#comment269791> This is not necessary. You just need to pull the `slave->apply` part this this function. src/master/master.cpp Lines 10878-10893 (original) <https://reviews.apache.org/r/64054/#comment269792> You just need to adjust this part. The rest should not be touched. - Jie Yu On Nov. 24, 2017, 11:24 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64054/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2017, 11:24 a.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Applying operations has been refactored out of 'addOfferOperation' and > simplified by using 'protobuf::isSpeculativeOperation'. > > > Diffs > ----- > > src/master/master.hpp 2a2e830354db4a2191fb8321beb8174b80f7ba7d > src/master/master.cpp 53263e499d88b906b6406c24c0dfb737e589e813 > src/slave/slave.cpp f93ff7b20815c3ccb274ce6990ee66a17b6ac51c > > > Diff: https://reviews.apache.org/r/64054/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
