-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63816/
-----------------------------------------------------------
(Updated Nov. 29, 2017, 2:48 p.m.)
Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and
Michael Park.
Changes
-------
Rebased.
Bugs: MESOS-6816
https://issues.apache.org/jira/browse/MESOS-6816
Repository: mesos
Description
-------
By removing the explicit system environment override code, and instead
setting the system environment as the default in the `CreateProcess`
wrapper, the `SlaveTest.ExecutorEnvironmentVariables` can be enabled.
Note that this also required fixing `os::host_default_path()` and using
it, because the test used `PATH = /bin`, which breaks on Windows.
Diffs (updated)
-----
src/slave/containerizer/docker.cpp 9918d83cad3a73242de09819ef9beabdbdca2a94
src/slave/containerizer/mesos/launch.cpp
4fabf9228f1699d07cd6dd6d1752bac096ce76c1
src/tests/slave_tests.cpp b35497bfa9363815845f339b6c3a7f871932b26d
Diff: https://reviews.apache.org/r/63816/diff/3/
Changes: https://reviews.apache.org/r/63816/diff/2-3/
Testing
-------
Thanks,
Andrew Schwartzmeyer