----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64183/#review192198 -----------------------------------------------------------
Ship it! We'll commit this quick fix first. When https://reviews.apache.org/r/64008/ is ready, that review will need to add the deleted code back. - Joseph Wu On Nov. 29, 2017, 3:15 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64183/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2017, 3:15 p.m.) > > > Review request for mesos and Andrew Schwartzmeyer. > > > Bugs: MESOS-8277 > https://issues.apache.org/jira/browse/MESOS-8277 > > > Repository: mesos > > > Description > ------- > > Commit 17d186e379d2db3edb04743a061dc05e24c32c9b introduced a > 0 size array in `mesos::internal::master::MASTER_CAPABILITIES()`. This > is not valid C++, but instead a GCC C++ extension, so it broke the > Windows build. Since `MASTER_CAPABILITIES()` just returns an empty > vector for now, the code now just simply returns `{}`. > > > Diffs > ----- > > src/master/constants.cpp bf3d3e449d2df7c2ff18dc8891500b03da98d096 > > > Diff: https://reviews.apache.org/r/64183/diff/1/ > > > Testing > ------- > > Compiled on Windows. Currently compiling on Linux. > > > Thanks, > > Akash Gupta > >
