----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63811/#review192210 -----------------------------------------------------------
Ship it! Ship It! - Akash Gupta On Nov. 29, 2017, 10:47 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63811/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2017, 10:47 p.m.) > > > Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and > Michael Park. > > > Bugs: MESOS-6735 > https://issues.apache.org/jira/browse/MESOS-6735 > > > Repository: mesos > > > Description > ------- > > This is the opposite of `get_handle_no_follow`. They both use the > inappropriately named Windows API `CreateFile` to retrieve a `HANDLE` to > an existing file or directory. This existing `get_handle_no_follow` > explicitly gets a handle to the symlink itself, and the new > `get_handle_follow` explicitly resolves symlinks and gets a handle to > the target. > > This may fail if the target doesn't exist. > > > Diffs > ----- > > 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp > e3d04480cf793482d958ea9571d96a29b6bf09b1 > > > Diff: https://reviews.apache.org/r/63811/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >