> On Nov. 29, 2017, 7:45 p.m., Andrew Schwartzmeyer wrote: > > Ship It!
This is committed: commit 5574681dd (HEAD -> master, apache/master, apache/HEAD) Author: Akash Gupta <[email protected]> Date: Wed Nov 29 19:45:02 2017 -0800 Fixed Windows `HealthCheckTest.HealthyTaskViaTCP` test failure. `int socket = socket()` was used instead of `int_fd socket = ...`, causing Windows to use the wrong `WindowsFD` constructor, throwing an assertion failure. Review: https://reviews.apache.org/r/64188/ I just don't have permissions to close other people's reviews yet. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64188/#review192234 ----------------------------------------------------------- On Nov. 29, 2017, 4:41 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64188/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2017, 4:41 p.m.) > > > Review request for mesos and Andrew Schwartzmeyer. > > > Repository: mesos > > > Description > ------- > > `int socket = ::socket()` was used instead of `int_fd socket = ...`, > causing Windows to use the wrong `WindowsFD` constructor, throwing > an assertion failure. > > > Diffs > ----- > > src/checks/tcp_connect.cpp 17d7abf924557568137dded9d1f0729213b8e4a9 > > > Diff: https://reviews.apache.org/r/64188/diff/1/ > > > Testing > ------- > > Ran HealthCheckTest.HealthyTaskViaTCP on Windows + Linux. > > > Thanks, > > Akash Gupta > >
