----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64094/#review192377 -----------------------------------------------------------
Fix it, then Ship it! src/messages/messages.cpp Lines 213 (patched) <https://reviews.apache.org/r/64094/#comment270477> Could you put these two params on separate lines? src/messages/messages.proto Lines 739 (patched) <https://reviews.apache.org/r/64094/#comment270476> s/the the/the/ ;-) - Greg Mann On Nov. 27, 2017, 7:51 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64094/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2017, 7:51 p.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-8197 > https://issues.apache.org/jira/browse/MESOS-8197 > > > Repository: mesos > > > Description > ------- > > This protobuf message is used to checkpoint offer operation status > updates and acknowledgments. > > > Diffs > ----- > > src/messages/messages.hpp 2756ebae5e2dccce63030eb7cec55d35445fa97b > src/messages/messages.cpp 6029502e8394817a0ab6ee2f63895ad02349bb0d > src/messages/messages.proto d7ef68f85a9f8a7702a83a3554c2dedc6d7ee339 > > > Diff: https://reviews.apache.org/r/64094/diff/1/ > > > Testing > ------- > > Added new tests at the end of the chain. They passed 5000 times on GNU/Linux. > > > Thanks, > > Gaston Kleiman > >
