----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/#review192381 -----------------------------------------------------------
src/CMakeLists.txt Lines 487 (patched) <https://reviews.apache.org/r/64096/#comment270487> Perhaps the filenames 'offer_operation.{cpp,hpp}' would suffice, since they sit within the 'status_update_manager' directory. WDYT? src/status_update_manager/offer_operation_status_update_manager.hpp Lines 17-18 (patched) <https://reviews.apache.org/r/64096/#comment270499> s/PROCESS_// src/status_update_manager/offer_operation_status_update_manager.hpp Lines 46-47 (patched) <https://reviews.apache.org/r/64096/#comment270505> Let's be a little more explicit here: "called in order to forward a new status update to its recipient." src/status_update_manager/offer_operation_status_update_manager.hpp Lines 79 (patched) <https://reviews.apache.org/r/64096/#comment270688> s/exist/exist or is empty/ src/status_update_manager/offer_operation_status_update_manager.hpp Lines 80-83 (patched) <https://reviews.apache.org/r/64096/#comment270689> Need to update this comment and the signature for the `strict` param. src/status_update_manager/offer_operation_status_update_manager.hpp Lines 91-97 (patched) <https://reviews.apache.org/r/64096/#comment270691> Can be removed. src/status_update_manager/offer_operation_status_update_manager.hpp Lines 102 (patched) <https://reviews.apache.org/r/64096/#comment270716> Let's use an `Owned` here instead of a raw pointer. src/status_update_manager/offer_operation_status_update_manager.cpp Lines 36-38 (patched) <https://reviews.apache.org/r/64096/#comment270722> I think it's a bit more consistent with the spirit of our style guide (i.e. to reduce "jaggedness") to wrap after the '<' and indent 4 spaces: ``` process = new StatusUpdateManagerProcess< UUID, OfferOperationStatusUpdateRecord, OfferOperationStatusUpdate>(); ``` http://mesos.apache.org/documentation/latest/c++-style-guide/#function-definition-invocation Could you switch to that format throughout this chain? - Greg Mann On Dec. 1, 2017, 12:27 a.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64096/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2017, 12:27 a.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-8197 > https://issues.apache.org/jira/browse/MESOS-8197 > > > Repository: mesos > > > Description > ------- > > This class will handle the offer operation status updates generated by > the agent and by resource providers. > > > Diffs > ----- > > src/CMakeLists.txt 76ef6cac925e36a31e4f6c347271955411284056 > src/Makefile.am 4a3b728dc2cbfaf4b10068562778a87a6b331238 > src/status_update_manager/offer_operation_status_update_manager.hpp > PRE-CREATION > src/status_update_manager/offer_operation_status_update_manager.cpp > PRE-CREATION > src/tests/CMakeLists.txt 65fca826e8b46ad064096e0f02b771985bef95d0 > src/tests/offer_operation_status_update_manager_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/64096/diff/3/ > > > Testing > ------- > > This patch addes new tests that passed 5000 times on GNU/Linux. > > > Thanks, > > Gaston Kleiman > >
