----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64250/#review192531 -----------------------------------------------------------
docs/task-state-reasons.md Lines 370-372 (patched) <https://reviews.apache.org/r/64250/#comment270738> Should it be in the "Reasons for Non-Terminal Status Updates" section and is there a reason to refer to TASK_LOST? docs/task-state-reasons.md Lines 479 (patched) <https://reviews.apache.org/r/64250/#comment270740> "The task was part of an accepted offer": this is irrevelent to either TASK_UNREACHABLE or the reason REASON_SLAVE_REREGISTERED. docs/task-state-reasons.md Lines 480-482 (patched) <https://reviews.apache.org/r/64250/#comment270741> We don't need to put too much details on TASK_UNREACHABLE since it's described elsewhere. docs/task-state-reasons.md Lines 483-485 (patched) <https://reviews.apache.org/r/64250/#comment270744> I think we can just focus on: - This is sent when an agent previously marked as unreachable re-registers. - Status updates with this reason are not the original ones, see the comments for `REASON_RECONCILIATION`. include/mesos/mesos.proto Lines 2406 (patched) <https://reviews.apache.org/r/64250/#comment270736> I think has convention used here is to order the reasons alphabetically. include/mesos/v1/mesos.proto Lines 2387 (patched) <https://reviews.apache.org/r/64250/#comment270737> Ditto. - Jiang Yan Xu On Dec. 1, 2017, 8:20 a.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64250/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2017, 8:20 a.m.) > > > Review request for mesos, Ilya Pronin, James Peach, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Added new reasons `REASON_SLAVE_REREGISTERED` and > `REASON_AGENT_REREGISTERED` for v0 and v1 task status update. > The new reason will be used when master starts to send status > update during the re-registeration of an agent which was > previosuly removed by the master because of being unreachable. > > > Diffs > ----- > > docs/task-state-reasons.md 07f7927e28fe5624a6c9b74de731483aaa729ca3 > include/mesos/mesos.proto 11089b7d6f48f001ae64e8b0c67a2732684aa2fa > include/mesos/v1/mesos.proto c496da927903f472c78d455b7fdf886d8fb692c4 > > > Diff: https://reviews.apache.org/r/64250/diff/1/ > > > Testing > ------- > > > Thanks, > > Megha Sharma > >
