----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64264/#review192616 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/containerizer.hpp Lines 182-184 (original), 183-185 (patched) <https://reviews.apache.org/r/64264/#comment270876> Not yours. Can we swap these two lines to make it consistent with the declaration in `MesosContainerizer`. src/slave/containerizer/mesos/containerizer.cpp Lines 2839-2841 (patched) <https://reviews.apache.org/r/64264/#comment270878> Just a nit. I think we'd better to handle `containers_` first and then `excludedImages`, so what about moving these code at line 2864? src/tests/containerizer.hpp Line 127 (original), 127 (patched) <https://reviews.apache.org/r/64264/#comment270879> Kill ` excludedImages`. - Qian Zhang On Dec. 2, 2017, 9:10 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64264/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2017, 9:10 a.m.) > > > Review request for mesos, Jie Yu, Qian Zhang, Vinod Kone, and Zhitao Li. > > > Bugs: MESOS-8295 > https://issues.apache.org/jira/browse/MESOS-8295 > > > Repository: mesos > > > Description > ------- > > Added excluded image parameter to containerizer pruneImages(). > > > Diffs > ----- > > src/slave/containerizer/composing.hpp > 3d006093f484308311e054fdd1d3d27bab3f37cd > src/slave/containerizer/composing.cpp > 83880962c004e259619b123db8196ee8293683a8 > src/slave/containerizer/containerizer.hpp > 7a0c6fc6452325a318d9e1c91874098e401bc1ea > src/slave/containerizer/docker.hpp 9df98499bb7f334d8595e22ac93126453296a0f2 > src/slave/containerizer/docker.cpp d837442ca073d6872c94a9332599423c005a8874 > src/slave/containerizer/mesos/containerizer.hpp > e2739e017cb8dda37d94ad809ca1bd461f308bfb > src/slave/containerizer/mesos/containerizer.cpp > 44e8f7acc0302f68cd237bc27fe01131a1475711 > src/tests/containerizer.hpp 3d162fecf03baf4747fa8b833fb0292d55195003 > src/tests/containerizer.cpp 665bd5d3968e47c243b5a47589715d1649066183 > src/tests/containerizer/mock_containerizer.hpp > bbfa7681a874158caf085d132b16b59b74a0c4ab > > > Diff: https://reviews.apache.org/r/64264/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
