> On Dec. 4, 2017, 3:20 p.m., Jan Schlicht wrote: > > src/slave/slave.hpp > > Line 680 (original), 681 (patched) > > <https://reviews.apache.org/r/63389/diff/6/?file=1892607#file1892607line681> > > > > Would it make sense to remove the `#include > > "resource_provider/manager.hpp"` and use a forward declaration now that > > this is a pointer?
Oops... I was considering drop this patch since this is workaround for testing when we didn't have any master-side code. Thsts why this ons is not rebased yet. Shound have remove the list of reviewers. My bad. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63389/#review192690 ----------------------------------------------------------- On Nov. 15, 2017, 2:46 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63389/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2017, 2:46 a.m.) > > > Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht. > > > Bugs: MESOS-8144 > https://issues.apache.org/jira/browse/MESOS-8144 > > > Repository: mesos > > > Description > ------- > > This patch adds a `ResourceProviderManager*` parameter to the slave > constructor, so we can pass in a mock resource provider manager. The > mock manager can be used to test against either the agent or the > resource provider. > > The declaration of `ResourceProviderManagerProcess` is moved to a > separated `manager_process.hpp` header file so we can mock the internal > process. > > > Diffs > ----- > > src/Makefile.am 955f01a665019d7750980ff16f126ad63b524594 > src/local/local.cpp 99c1b087d75a1759ed61a4e6178e15919bee1e77 > src/resource_provider/manager.hpp e7a9a6cc6b15372d8f3f11e17fa2297792b00ff9 > src/resource_provider/manager.cpp 6dfc42900a1e4249f37cec585f7fe50f5aa94e43 > src/resource_provider/manager_process.hpp PRE-CREATION > src/slave/main.cpp 94431b036524ef4db16a594c80f45b64a45728f7 > src/slave/slave.hpp c0acaa639a2bacaa6955ae6c5ab41e75dc1d11f7 > src/slave/slave.cpp d8bacebc74790e955490a158c37ac0d9e75fd6b5 > src/tests/cluster.hpp 65634121b7fe076a7cd9a1c5aa6101a96b1c009d > src/tests/cluster.cpp d657da6d84e5ea28e0dad180dce069de569c5d38 > src/tests/mesos.hpp f25173232df4a9b460194e5e041230e307b80e36 > src/tests/mesos.cpp 9185b5bf2175be5b0f6b6a03a04e9e5445bf22fd > src/tests/mock_slave.hpp 57189cee20511d145ae6b47a4dc2c66a14638dad > src/tests/mock_slave.cpp db24f9e5b71f558d2f811f0da8a9cc9c7c2dd341 > src/tests/resource_provider/mock_manager.hpp PRE-CREATION > src/tests/resource_provider/mock_manager.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/63389/diff/6/ > > > Testing > ------- > > make > > > Thanks, > > Chun-Hung Hsiao > >
