----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64272/#review192753 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Dec. 1, 2017, 11:37 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64272/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2017, 11:37 p.m.) > > > Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Replaced the two maps of `ContainerId -> pid` and `ContainerId -> limit` > with a mapping of `ContainerId -> struct Info { pid, limit }`. This > abstraction correctly ties the the `pid` and cpu/mem `limit` together. > Notably this fixes a subtle bug in `prepare` so that it can no longer be > called multiple times if a resource limit hadn't been set. > > Furthermore, this patch imports all the types used in the source files > to enchance code conciseness, and then reformatted with `clang-format`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/windows/cpu.hpp > 8672b5943ff305b929dd7514581df4515dff1f50 > src/slave/containerizer/mesos/isolators/windows/cpu.cpp > e9f4daccdd507312998984cad231c3c7d310af2b > src/slave/containerizer/mesos/isolators/windows/mem.hpp > 24426f7219bc7831c1682153d7c9c1a6e502e3d6 > src/slave/containerizer/mesos/isolators/windows/mem.cpp > 5abcb4edfa350e1de5b34bfd43d4e961b7208799 > > > Diff: https://reviews.apache.org/r/64272/diff/2/ > > > Testing > ------- > > `make check` on CentOS 7 (probably pointless) > > `ctest` on Windows 10. All tests passed. (Building again after rebase.) > > > Thanks, > > Andrew Schwartzmeyer > >
