----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64312/#review192779 -----------------------------------------------------------
Fix it, then Ship it! docs/reservation.md Line 83 (original), 96 (patched) <https://reviews.apache.org/r/64312/#comment271034> Labeled reservation is now a sub-section of reservation refinement? Seems wrong? Should it be it's own top-level section? docs/upgrades.md Lines 108 (patched) <https://reviews.apache.org/r/64312/#comment271033> Hm.. I'm not sure we should mention this here, it's a bit confusing to metion an "internal Mesos c++ library" as part of the framework API? We could have a c++ public headers section but since we break it all the time and haven't been publishing the changes here I'd probably shy away from that. - Benjamin Mahler On Dec. 4, 2017, 9:58 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64312/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2017, 9:58 p.m.) > > > Review request for mesos, Benjamin Mahler and Joerg Schad. > > > Bugs: MESOS-7663 > https://issues.apache.org/jira/browse/MESOS-7663 > > > Repository: mesos > > > Description > ------- > > Added reservation refinement documentation. > > > Diffs > ----- > > docs/reservation.md 3a42783deb5b8ad288e626612c196bfd8439d299 > docs/upgrades.md 33ba4a69e6e53a313e89a3a24448e3e551443e23 > > > Diff: https://reviews.apache.org/r/64312/diff/2/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
