> On Dec. 4, 2017, 3:20 p.m., Benjamin Bannier wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 676 (patched) > > <https://reviews.apache.org/r/64238/diff/1/?file=1905334#file1905334line683> > > > > We will only call `addResourceProvider` after `slaveId` has been added > > to the allocator (`addResourceProvider` is triggered by > > `UpdateSlaveMessage` which will only be sent after registration). > > > > We still might run into case (2) here where there are pending offer > > operations by some framework on the added resource provider and we never > > ran any tasks from that framework on that agent so the `FrameworkInfo` is > > unknown to the agent. > > Benjamin Mahler wrote: > That sounds like a bug in the new provider logic? Shouldn't the agent be > sending the framework info in that case? > > Benjamin Bannier wrote: > My comment above is incorrect. I missed that we broadcast any new > framework's `FrameworkInfo` on framework subscription; in that case we would > always send the agent the `FrameworkInfo` before sending operations from that > framework, and consequentially any `UpdateSlaveMessage` sent during agent > resource and offer operation reconciliation after a master failover should > only contain operations from frameworks already known to the new master from > `ReregisterSlaveMessage`.
Ok, I won't CHECK for it for now (up to you if you want to do a more careful reading of the code and CHECK it) but I will say it shouldn't be possible. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64238/#review192695 ----------------------------------------------------------- On Dec. 1, 2017, 1:05 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64238/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2017, 1:05 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, Michael Park, and Meng > Zhu. > > > Repository: mesos > > > Description > ------- > > A helper was introduced for tracking allocated resources in the > sorters. This updates the code to allow the other two copies of > this code to use the function. > > This also documents some of the addFramework/addSlave cases. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 3c87dc797cf70f3aa48b1ed9f86d673d4ea2fe76 > src/master/allocator/mesos/hierarchical.cpp > ab2abf868f9252154d934243521622c5cb107182 > > > Diff: https://reviews.apache.org/r/64238/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
