> On Dec. 4, 2017, 5:57 p.m., Michael Park wrote: > > src/master/master.cpp > > Line 6433 (original), 6394 (patched) > > <https://reviews.apache.org/r/63914/diff/4/?file=1904566#file1904566line6438> > > > > I think these `message` to `message_` changes should either take the > > type of the mesage (e.g., `shutdown`), or simply a `s/message/outgoing/`. > > Having unrelated `message` and `message_` in the same scope will likely > > cause confusion.
Maybe it's better change `ReregisterSlaveMessage` name to `request` and keep `message` in other places? I tried using names like `checkpointResourcesMessage` as bmahler suggested below, but lines became too long and wrapping was required. Names like `shutdown` should work, but this will be inconsistent with other code in this file. - Dmitry ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63914/#review192721 ----------------------------------------------------------- On Nov. 21, 2017, 5:53 p.m., Dmitry Zhuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63914/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 5:53 p.m.) > > > Review request for mesos, Benjamin Mahler and Michael Park. > > > Bugs: MESOS-6972 > https://issues.apache.org/jira/browse/MESOS-6972 > > > Repository: mesos > > > Description > ------- > > `reregisterSlave` now accepts `ReregisterSlaveMessage&&`, which opts-out > of using protobuf arena, and allows passing message through dispatch > chain without making any copies. > Conversion of repeated message fields to `std::vector`s is performed > only when needed. > > > Diffs > ----- > > src/master/master.hpp 0f8a2ac72c3484f911853c2994fc71a488d66d96 > src/master/master.cpp fadc78b2ca5d46b8cc12a794b428753aa79ac095 > src/master/validation.hpp ac54062ea09f97ad96bd17deb106ea89a57f394a > src/master/validation.cpp 8b5848bfd8c069f34a92a9a68597955c6e0c2ee2 > src/tests/master_validation_tests.cpp > 0e1c8b490ebe10bc50b8b6b530fa85128b967584 > > > Diff: https://reviews.apache.org/r/63914/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Dmitry Zhuk > >
