----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/#review192905 -----------------------------------------------------------
Fix it, then Ship it! src/tests/hierarchical_allocator_tests.cpp Line 6283 (original) <https://reviews.apache.org/r/64011/#comment271248> Let's actually pause the clock in this test. - Vinod Kone On Dec. 5, 2017, 4:14 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64011/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2017, 4:14 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > When an agent reregisters, the master will now always update > the agent information it holds in memory, and will write any > changes back to the registry if necessary. > > Note that most tests for this are added in a later review, since they > require the capability to actually restart the agent with > a changed state to effectively test the masters response to that. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 3c87dc797cf70f3aa48b1ed9f86d673d4ea2fe76 > src/master/allocator/mesos/hierarchical.cpp > 715650ee9cb15aed1d1e58badf70fc09e26d13c1 > src/master/master.hpp 5d2ae658070d9c5a0bc630c15ff89dc449857f46 > src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4 > src/tests/hierarchical_allocator_tests.cpp > 0309074bab180be122c9b0074981e6f69c97feee > > > Diff: https://reviews.apache.org/r/64011/diff/8/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
