----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64335/#review193072 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Dec. 5, 2017, 10:59 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64335/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2017, 10:59 a.m.) > > > Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu. > > > Repository: mesos > > > Description > ------- > > The "agent_features" was implemented in a block that was only compiled > on Linux. As it should be available on every target system, the > implementation has been move out of the block. > > > Diffs > ----- > > src/slave/flags.cpp 34edf4cb4a1afc366e6b6b4ddf78e90e49853fdf > > > Diff: https://reviews.apache.org/r/64335/diff/1/ > > > Testing > ------- > > make check > > Ran `src/mesos-agent --help` on macOS and checked that the `agent_feature` > flag is listed there. > > > Thanks, > > Jan Schlicht > >