> On Dec. 7, 2017, 3:17 a.m., Jie Yu wrote: > > src/tests/slave_tests.cpp > > Lines 8961-8964 (patched) > > <https://reviews.apache.org/r/63555/diff/2/?file=1909793#file1909793line8961> > > > > Can we call `subscribedDefault`?
If we do not intercept `subscribed` calls, then we cannot get the resource provider ID, and thus cannot set `providerResources` appropriately for offer matching. I can use `OffersHaveAnyResource` and set up a filter instead. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63555/#review193083 ----------------------------------------------------------- On Dec. 6, 2017, 8:07 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63555/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2017, 8:07 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Joseph Wu, and Jan Schlicht. > > > Bugs: MESOS-7550 > https://issues.apache.org/jira/browse/MESOS-7550 > > > Repository: mesos > > > Description > ------- > > `Slave::publishAllocatedResources()` will compute the total allocated > resources for all currently running executor containers, and takes an > `extra` argument for resources that will be used by the executor that > is about to launch, then sums them up and asks the resource provider > manager to publish the resources. > > > Diffs > ----- > > src/resource_provider/manager.cpp 8d8b2f1396230d6edba590b8b7e9b4ca51366efe > src/slave/slave.hpp 643d8559244f0842e82b293c1ef99cb26e111059 > src/slave/slave.cpp c07e25f668bef6b6fa3cae4b69ba90de3eb3bdcc > src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2 > src/tests/slave_tests.cpp a7f6658fa467914cd74691b5631d26d85ba7c1eb > > > Diff: https://reviews.apache.org/r/63555/diff/2/ > > > Testing > ------- > > The test is still broken. Will fix it later. > > > Thanks, > > Chun-Hung Hsiao > >
