> On Dec. 7, 2017, 7:58 p.m., Benjamin Mahler wrote: > > I also have a patch I was going to send out to eliminate these copies along > > with some others. I had taken an rvalue reference here, did you avoid that > > in order to support both callers that move and callers that do not? > > Dmitry Zhuk wrote: > Yes, this was the reason. Rvalue reference should also work here.
Here's where I used an rvalue reference and eliminated some other copies: https://reviews.apache.org/r/64428/ - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64416/#review193154 ----------------------------------------------------------- On Dec. 7, 2017, 5:33 p.m., Dmitry Zhuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64416/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2017, 5:33 p.m.) > > > Review request for mesos, Benjamin Mahler and Michael Park. > > > Repository: mesos > > > Description > ------- > > Moved tasks from completed frameworks during agent reregistration. > > > Diffs > ----- > > src/master/master.hpp 2658312b0d10a72fefda68c7d3137b94afbd8249 > src/master/master.cpp 2fd66c072e9a194680d7653c664bd8a68ea1d2f0 > > > Diff: https://reviews.apache.org/r/64416/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Dmitry Zhuk > >
