----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64425/#review193206 -----------------------------------------------------------
FAIL: Some Mesos libprocess-tests failed. Reviews applied: `['64370', '64151', '64422', '64423', '64424', '64425']` Failed command: `C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64425 Relevant logs: - [libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64425/logs/libprocess-tests-stdout.log): ``` C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp(440): error: Failed to wait 15secs for socket [ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0, where GetParam() = "false" (16790 ms) [ RUN ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1 C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp(440): error: Failed to wait 15secs for socket [ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1, where GetParam() = "true" (16845 ms) [----------] 4 tests from SSLVerifyIPAdd/SSLTest (34909 ms total) [----------] Global test environment tear-down [==========] 223 tests from 35 test cases ran. (264793 ms total) [ PASSED ] 209 tests. [ FAILED ] 14 tests, listed below: [ FAILED ] SSLTest.SSLSocket [ FAILED ] SSLTest.NonSSLSocket [ FAILED ] SSLTest.NoVerifyBadCA [ FAILED ] SSLTest.RequireBadCA [ FAILED ] SSLTest.VerifyBadCA [ FAILED ] SSLTest.VerifyCertificate [ FAILED ] SSLTest.ProtocolMismatch [ FAILED ] SSLTest.ECDHESupport [ FAILED ] SSLTest.ValidDowngrade [ FAILED ] SSLTest.NoValidDowngrade [ FAILED ] SSLTest.ValidDowngradeEachProtocol [ FAILED ] SSLTest.NoValidDowngradeEachProtocol [ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0, where GetParam() = "false" [ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1, where GetParam() = "true" 14 FAILED TESTS YOU HAVE 19 DISABLED TESTS ``` - [libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64425/logs/libprocess-tests-stderr.log): ``` I1208 01:13:29.091105 9600 process.cpp:887] Failed to accept socket: future discarded I1208 01:13:29.289225 6932 process.cpp:887] Failed to accept socket: future discarded I1208 01:13:30.123196 8632 openssl.cpp:514] Will not verify peer certificate! NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification I1208 01:13:30.123196 8632 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification. LIBPROCESS_SSL_VERIFY_CERT set to true I1208 01:13:30.124197 8632 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\8aMXIr\cert.pem I1208 01:13:30.124197 8632 openssl.cpp:566] Using CA dir: C:\Users\mesos\AppData\Local\Temp\8aMXIr I1208 01:13:30.539273 8632 openssl.cpp:514] Will not verify peer certificate! NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification I1208 01:13:30.539273 8632 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension. I1208 01:13:30.539273 8632 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification. LIBPROCESS_SSL_VERIFY_CERT set to true I1208 01:13:30.550282 8632 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\qT5VUY\cert.pem I1208 01:13:30.550282 8632 openssl.cpp:566] Using CA dir: C:\Users\mesos\AppData\Local\Temp\qT5VUY I1208 01:13:31.318717 8632 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath> I1208 01:13:31.318717 8632 openssl.cpp:514] Will not verify peer certificate! NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification I1208 01:13:31.318717 8632 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification. LIBPROCESS_SSL_VERIFY_CERT set to true I1208 01:13:31.319717 8632 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\dFjTFm\cert.pem I1208 01:13:48.202466 8632 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath> I1208 01:13:48.202466 8632 openssl.cpp:514] Will not verify peer certificate! NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification I1208 01:13:48.202466 8632 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension. I1208 01:13:48.202466 8632 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification. LIBPROCESS_SSL_VERIFY_CERT set to true I1208 01:13:48.203466 8632 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\9gnCeB\cert.pem I1208 01:14:04.343842 3236 process.cpp:887] Failed to accept socket: future discarded ``` - Mesos Reviewbot Windows On Dec. 8, 2017, 12:17 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64425/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2017, 12:17 a.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > The code in 'getResourceProviderId' was written in a way assuming that > any operation containing a list resources always contained at least a > single resource. This is both incorrect since such operations pass > validation, and also neglects to check a crucial precondition since > accessing a non-existent element in this context would lead to a check > failure in protobuf and a subsequent abort. > > This code updates 'getResourceProviderId' to check the precondition of > operations holding at least one element. > > > Diffs > ----- > > src/common/resources_utils.cpp 8e3d3044e7c4e2d0372ce8fb3908fdf7aab6c169 > > > Diff: https://reviews.apache.org/r/64425/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
