> On Dec. 11, 2017, 11:24 a.m., Benjamin Bannier wrote: > > src/slave/slave.cpp > > Lines 7294 (patched) > > <https://reviews.apache.org/r/64477/diff/2/?file=1912141#file1912141line7387> > > > > Since it is possible to e.g., `RESERVE` an empty `Resources`, I believe > > we could currently trigger this `CHECK`. > > > > Even if we added master validation in the future it is still tricky to > > decide what status update manager should keep track of reliably sending the > > update. I think it would make sense to bookkeep this operation in a failed > > state to the agent so its status update manager can in the future deliver > > the offer operation status to the framework. > > > > For now we could just drop operations without an extractable resource > > provider id here with some logging and a `TODO`.
I prefer to use a CHECK here. I'll add a TODO to fix the master validation. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64477/#review193380 ----------------------------------------------------------- On Dec. 10, 2017, 5:11 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64477/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2017, 5:11 p.m.) > > > Review request for mesos, Benjamin Bannier, Greg Mann, and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > Currently, we don't explicitly keep track of local resources providers. > This causes the logic for a few methods to be quite complex because we > need to reconstruct the resource provider information everytime. > > > Diffs > ----- > > src/resource_provider/manager.cpp f98611c351f11b15281dd3ef673ef80db1c44f07 > src/resource_provider/message.hpp bbf6bb2a0a4aa901ac038cdbe4dd46acc0f2e453 > src/slave/http.cpp 738786fc4b85903f187cf0988a3fca488ea2767d > src/slave/slave.hpp b3a1e70169ed1abbfc815821771715197a63f2df > src/slave/slave.cpp 373e393ca1e7c0c30c3474cc9e630e25ad92f235 > src/tests/resource_provider_manager_tests.cpp > a6eb4c9a303780029244e069bdf550a8cd9c7bb4 > > > Diff: https://reviews.apache.org/r/64477/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
