----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64493/#review193728 -----------------------------------------------------------
Fix it, then Ship it! Just some minor suggestions below, I will take care of these and get this committed shortly! src/tests/hierarchical_allocator_tests.cpp Lines 1274-1276 (patched) <https://reviews.apache.org/r/64493/#comment272333> This comment is stale? src/tests/hierarchical_allocator_tests.cpp Lines 1288-1289 (patched) <https://reviews.apache.org/r/64493/#comment272335> Fits on one line? src/tests/hierarchical_allocator_tests.cpp Lines 1355-1356 (patched) <https://reviews.apache.org/r/64493/#comment272338> Maybe a little more explanation here? ``` // Agent2's resources should not be allocated to `framework1` under // `QUOTA_ROLE` because the reserved resources should be accounted // towards the quota and allocating this agent will exceed the // quota limit. ``` src/tests/hierarchical_allocator_tests.cpp Lines 1367-1368 (patched) <https://reviews.apache.org/r/64493/#comment272336> Fits on one line? src/tests/hierarchical_allocator_tests.cpp Lines 1394 (patched) <https://reviews.apache.org/r/64493/#comment272340> This might be helpful to the reader? ``` // Set a quota for 2x agent resources. ``` src/tests/hierarchical_allocator_tests.cpp Lines 1429-1431 (patched) <https://reviews.apache.org/r/64493/#comment272341> I thought we also wanted to then add a third agent and ensure it's not allocated to the role? - Benjamin Mahler On Dec. 13, 2017, 2:53 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64493/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2017, 2:53 a.m.) > > > Review request for mesos, Benjamin Mahler and Michael Park. > > > Bugs: MESOS-4527 > https://issues.apache.org/jira/browse/MESOS-4527 > > > Repository: mesos > > > Description > ------- > > Added tests for quota enforcement with unallocated reservations. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 862f4683da04d37d9fe9f471d6ec9cd7751f39ec > > > Diff: https://reviews.apache.org/r/64493/diff/3/ > > > Testing > ------- > > maek check > > > Thanks, > > Meng Zhu > >
